Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CubestoreMetadataCacheFactory and TableExtensionService DIServices #8625

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

srh
Copy link
Member

@srh srh commented Aug 23, 2024

Draft PR

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 7:47am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 7:47am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 7:47am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 7:47am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 7:47am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 7:47am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 7:47am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 7:47am

@srh srh force-pushed the metadata-cache-factory branch 2 times, most recently from 26409e7 to 2bdbd44 Compare August 28, 2024 07:48
@srh srh changed the title Metadata cache factory draft Create CubestoreMetadataCacheFactory and TableExtensionService DIServices Aug 28, 2024
@srh srh marked this pull request as ready for review August 28, 2024 07:55
@srh srh requested a review from a team as a code owner August 28, 2024 07:55
@srh srh force-pushed the metadata-cache-factory branch 2 times, most recently from 85c683c to 0a0b025 Compare September 5, 2024 03:08
Copy link
Member

@waralexrom waralexrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@srh srh merged commit 7a7c8cb into master Sep 9, 2024
53 checks passed
@srh srh deleted the metadata-cache-factory branch September 9, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants