feat(cubesql): Support join with type coercion #8608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8608 +/- ##
==========================================
+ Coverage 82.56% 82.58% +0.01%
==========================================
Files 209 210 +1
Lines 77095 77148 +53
==========================================
+ Hits 63653 63710 +57
+ Misses 13442 13438 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
force-pushed
the
df-join-coercion
branch
from
f22143a
to
3d604b6
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
paveltiunov
approved these changes
Aug 26, 2024
mcheshkov
force-pushed
the
df-join-coercion
branch
from
3d604b6
to
cc19fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Bump datafusion to version with type coercion support for join. This is useful, for example, for introspection queries that join
pg_catalog.pg_attributewithpg_catalog.pg_descriptiononpg_attribute.attnum = pg_description.objsubid. Both can represent column number, butattnumisint2, andobjsubidisint4