BUG: Fix QueryBuilder to AVOID Maximum recursive updates exceeded #8556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Maximum recursive updates exceeded
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
github-actions
bot
added
the
pr:community
nsandroni
changed the title
|
@nsandroni, Could you please write a unit test for it? Thanks |
|
it turned out that not only prevValidatedQuery can cause a computed loop, but also pivotConfig and every parameter of the query saved inside copyQueryFromProps (that are used inside the validation), i added a check before the update to prevent computed loop with the same values |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Maximum recursive updates exceeded
Check List
Issue Reference this PR resolves
Passing a dynamic query to the query builder, can cause "Maximum recursive updates exceeded"
Description of Changes Made (if issue reference is not provided)
Avoiding the preValidatedQuery mutation inside the computed block, the error is no loger thronw