fix(cubesql): Generate unique aliases for members of different cubes #8553
+31
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
MazterQyou
force-pushed
the
cubesql/column-realiasing-fix
branch
from
40016a1
to
9cb2deb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8553 +/- ##
==========================================
- Coverage 82.66% 82.66% -0.01%
==========================================
Files 217 217
Lines 78125 78126 +1
==========================================
- Hits 64583 64580 -3
- Misses 13542 13546 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ovr
approved these changes
Aug 7, 2024
MazterQyou
force-pushed
the
cubesql/column-realiasing-fix
branch
2 times, most recently
from
acc3e1d
to
a0f5a63
Compare
MazterQyou
force-pushed
the
cubesql/column-realiasing-fix
branch
2 times, most recently
from
0725164
to
1ba356b
Compare
MazterQyou
force-pushed
the
cubesql/column-realiasing-fix
branch
from
d82f84b
to
2d5b243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR fixes an issue with SQL push down SQL generator which would produce duplicate aliases when referencing cube members with the same name but different cubes.