Set user directory for openoffice processes #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bce6a82)
andreysubbotin
approved these changes
Feb 10, 2020
| @@ -45,7 +45,8 @@ | |||
| public OfficeConnection(String openOfficePath, Integer port, ProcessManager processManager, OfficeIntegration officeIntegration) { | |||
| this.port = port; | |||
| this.officeIntegration = officeIntegration; | |||
| this.oooServer = new OOServer(openOfficePath, OOServer.getDefaultOOoOptions(), "localhost", port, processManager); | |||
| this.oooServer = new OOServer(openOfficePath, OOServer.getDefaultOOoOptions(), | |||
| "localhost", port, processManager, officeIntegration); | |||
There was a problem hiding this comment.
Perhaps you should pass the temp directory name instead of OfficeIntegration?
Ilya-c
pushed a commit
that referenced
this pull request
Mar 30, 2020
andreysubbotin
pushed a commit
that referenced
this pull request
Nov 7, 2020
* Set user directory for the openOffice processes (-env:UserInstallation parameter)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently integration starts single openoffice process because -env:UserInstallation parameter isn't set. Setting this parameter allows us to start multiple openoffice processes each with separate port.
Directories for the processes are created in the OfficeIntegration#temporaryDirPath folder. If temporary directory isn't set, parameter won't be used.
Process directories named as ".ooserver_${host}_${port}" for example - ".ooserver_localhost_8100".
Also this pull request contains commit which adds sl4j logging which is useful during openoffice problems debugging:
bdee7e7