Remove BootstrapException in BootstrapConnector.connect

[kjordan2001]

Can this be changed to throw the original exception? There are a variety of things that can happen in the original exception that are hidden by wrapping it in a BootstrapException since the original isn't added to the stacktrace, instead it's in a separate getter that you'd have to get by going through the exception stack since it's wrapped again before we get it into an OpenOfficeException. I ask this because it was difficult for me to tell what was going on with a problem I had using yarg in an updated EC2 Beanstalk environment where a permission change in the tomcat home directory prevented it from making a .openoffice directory and it was immediately clear when I did my own version of BootstrapConnector that returned the original error.

[tinhol]

Hello.

Do you mean the following part of code?
if (i == 10) { throw new BootstrapException(ex.toString()); }

[kjordan2001]

No, more like in pull request #16 that I just added.

[tinhol]

Well, I'm not sure it's a good idea, because throws Throwable just does not mean anything certain, and does not help client to handle it at all.
Wouldn't it be sufficient if you get the original exception wrapped by BootstrapException (new BootstrapException(e)) instead of creating BootstrapException with source exception's text (new BootstrapException(ex.toString()))?

[kjordan2001]

That'd only be slightly better. Unfortunately that doesn't act like most other Exceptions do when you pass in another Exception as the constructor parameter. That only allows you to get it from getTargetException. It seems like it'd be better to have another exception type rather than using one from the OpenOffice API.

[tinhol]

Hello.

We will remove the BootstrapException from BootstrapConnector implementations in future releases.

[tinhol]

Hello.

The issue is resolved in master branch.