builders should reset state after build

cuba-platform · Nov 6, 2015 · c25ec7f · c25ec7f
1 parent 0f736a5
commit c25ec7f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/core/modules/core/src/com/haulmont/yarg/structure/impl/BandBuilder.java b/core/modules/core/src/com/haulmont/yarg/structure/impl/BandBuilder.java
@@ -57,6 +57,8 @@ public BandBuilder orientation(BandOrientation orientation) {
 
     public ReportBand build() {
         bandDefinition.validate();
-        return bandDefinition;
+        ReportBandImpl result = bandDefinition;
+        bandDefinition = new ReportBandImpl();
+        return result;
     }
 }
diff --git a/core/modules/core/src/com/haulmont/yarg/structure/impl/ReportBuilder.java b/core/modules/core/src/com/haulmont/yarg/structure/impl/ReportBuilder.java
@@ -63,7 +63,9 @@ public ReportBuilder name(String name) {
 
     public Report build() {
         report.validate();
-        return report;
+        ReportImpl result = report;
+        report = new ReportImpl();
+        return result;
     }
 
 }
diff --git a/core/modules/core/src/com/haulmont/yarg/structure/impl/ReportTemplateBuilder.java b/core/modules/core/src/com/haulmont/yarg/structure/impl/ReportTemplateBuilder.java
@@ -95,6 +95,8 @@ public ReportTemplateBuilder custom(CustomReport customReport) {
 
     public ReportTemplate build() {
         reportTemplate.validate();
-        return reportTemplate;
+        ReportTemplateImpl result = reportTemplate;
+        reportTemplate = new ReportTemplateImpl();
+        return result;
     }
 }