Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded openoffice available ports #81

Closed
zaharchenko-evgeny opened this issue Jun 5, 2018 · 3 comments
Closed

Fix hardcoded openoffice available ports #81

zaharchenko-evgeny opened this issue Jun 5, 2018 · 3 comments
Assignees
Labels
state: fixed Fixed by the developer type: bug Something isn't working ver: 6.10.0 ver: 7.0.0 Fixed in version
Milestone

Comments

@zaharchenko-evgeny
Copy link
Contributor

Environment

  • Platform version: 5.4 - 6.9

Description of the bug or enhancement

Currently for reporting_lib_OfficeIntegration bean application property cuba.reporting.openoffice.ports is ignored and only ports 8100, 8101, 8102, 8103 are hardcoded. Current reporting_lib_OfficeIntegration bean initialization:

<bean id="reporting_lib_OfficeIntegration"
          class="com.haulmont.reports.libintegration.CubaOfficeIntegration">
        <constructor-arg value="${cuba.reporting.openoffice.path?:/}"/>
        <constructor-arg>
            <list>
                <value>8100</value>
                <value>8101</value>
                <value>8102</value>
                <value>8103</value>
            </list>
        </constructor-arg>
        ...
    </bean>

Bean initialization should be updated to have ability to use cuba.reporting.openoffice.ports application property.
Fixed reporting_lib_OfficeIntegration bean initialization:

<bean id="reporting_lib_OfficeIntegration"
          class="com.haulmont.reports.libintegration.CubaOfficeIntegration">
        <constructor-arg value="${cuba.reporting.openoffice.path?:/}"/>
        <constructor-arg>
            <value>#{"${cuba.reporting.openoffice.ports?:8100|8101|8102|8103}".split('[,|]')}</value>
        </constructor-arg>
        ...
    </bean>
@zaharchenko-evgeny zaharchenko-evgeny added the type: bug Something isn't working label Jun 5, 2018
@andreysubbotin
Copy link
Contributor

andreysubbotin commented Jun 9, 2018

Related issue: cuba-platform/yarg#75

@haulmont-git
Copy link

Git changesets by subbotin:

ad06ac84 in release_6_10 - Fix hardcoded openoffice available ports #81

@haulmont-git haulmont-git added the ver: 7.0.0 Fixed in version label Jun 9, 2018
@haulmont-git
Copy link

Git changesets by subbotin:

abe35687 in master - Fix hardcoded openoffice available ports #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: fixed Fixed by the developer type: bug Something isn't working ver: 6.10.0 ver: 7.0.0 Fixed in version
Projects
None yet
Development

No branches or pull requests

4 participants