Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanvasUiComponentsFactory must not inject AppUI bean #19

Closed
jreznot opened this issue Jun 11, 2019 · 0 comments
Closed

CanvasUiComponentsFactory must not inject AppUI bean #19

jreznot opened this issue Jun 11, 2019 · 0 comments
Assignees
@zaharchenko-evgeny @zhenyazb
Labels
severity: major The defect affects major functionality. It has a workaround but is difficult. state: fixed Fixed by the developer type: bug Something isn't working ver: 3.0.3 Fixed in version
Milestone
Dashboard 3.0

Comments

@jreznot
Copy link
Contributor

jreznot commented Jun 11, 2019

Environment

  • Platform version: 7.0
  • Addon version: 3.0.2

Description of the bug or enhancement

CanvasUiComponentsFactory is a singleton bean and it must not inject AppUI bean. AppUI is a vaadin scoped bean and should be injected only to prototype scoped beans and UI screens.

See also https://www.cuba-platform.com/discuss/t/the-right-way-to-extend-appui/9322/4
@jreznot jreznot added severity: major The defect affects major functionality. It has a workaround but is difficult. type: bug Something isn't working labels Jun 11, 2019
@jreznot jreznot added this to the Dashboard 3.0 milestone Jun 11, 2019
zaharchenko-evgeny pushed a commit that referenced this issue Jun 18, 2019
CanvasUiComponentsFactory must not inject AppUI bean #19
3deaaa9
@zaharchenko-evgeny zaharchenko-evgeny added the state: fixed Fixed by the developer label Jun 18, 2019
@zaharchenko-evgeny zaharchenko-evgeny added the ver: 3.0.3 Fixed in version label Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaharchenko-evgeny zaharchenko-evgeny

@zhenyazb zhenyazb

Labels
severity: major The defect affects major functionality. It has a workaround but is difficult. state: fixed Fixed by the developer type: bug Something isn't working ver: 3.0.3 Fixed in version
Projects
None yet
Milestone
Dashboard 3.0
Development

No branches or pull requests
3 participants
@jreznot @zaharchenko-evgeny @zhenyazb