Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react 17 peer dependency. #201

Closed
wants to merge 1 commit into from
Closed

Conversation

bcomnes
Copy link

@bcomnes bcomnes commented Nov 5, 2020

Simple change, just increases the semver range of the react peer deps. Everything working good on 17 from what I can tell.

Simple change, just increases the semver range of the react peer deps.  Everything working good on 17 from what I can tell.
@Hypnosphi
Copy link

@ctrlplusb can you please review

@bcomnes
Copy link
Author

bcomnes commented Dec 2, 2020

Any chance for a quick review/merge/release? Would really help downstream issues with the new npm 7 peer dep changes. Thank you!

@bcomnes
Copy link
Author

bcomnes commented Jan 4, 2021

Happy new year! Is there anything I can do to help land this?

@Hypnosphi
Copy link

I've published your fork as @hypnosphi/react-sizeme

@bcomnes
Copy link
Author

bcomnes commented Jan 26, 2021

Awesome thank you @Hypnosphi for making this happen.

@brody4hire
Copy link

brody4hire commented Feb 25, 2021

Bump with a caveat: updating to react@17 gave me some test failures, needs further investigation.

@ctrlplusb
Copy link
Owner

I shall publish a version of this soon. 🙏

@brody4hire
Copy link

brody4hire commented Feb 26, 2021 via email

@ctrlplusb ctrlplusb closed this Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants