Merge pull request #130 from matmarchant/develop

Fix the return type for Commands in symfony console in v5.4.24
ctidigital · Jul 28, 2023 · 76fe8fb · 76fe8fb
2 parents 58c6774 + bb206f2
commit 76fe8fb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Console/Command/ListCommand.php b/Console/Command/ListCommand.php
@@ -35,7 +35,7 @@ protected function configure()
     /**
      * @param InputInterface $input
      * @param OutputInterface $output
-     * @return void
+     * @return int
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     protected function execute(InputInterface $input, OutputInterface $output)
@@ -52,6 +52,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
         } catch (ConfiguratorAdapterException $e) {
             $output->writeln('<error>' . $e->getMessage() . '</error>');
+            return Command::FAILURE;
         }
+        return Command::SUCCESS;
     }
 }
diff --git a/Console/Command/RunCommand.php b/Console/Command/RunCommand.php
@@ -64,7 +64,7 @@ protected function configure()
     /**
      * @param InputInterface $input
      * @param OutputInterface $output
-     * @return void
+     * @return int
      * @SuppressWarnings(PHPMD)
      */
     protected function execute(InputInterface $input, OutputInterface $output)
@@ -105,6 +105,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
         } catch (\Exception $e) {
             $output->writeln('<error>' . $e->getMessage() . '</error>');
+            return Command::FAILURE;
         }
+        return Command::SUCCESS;
     }
 }