Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added addLocalFolderAsync2 #501

Merged
merged 5 commits into from
Jun 9, 2024
Merged

added addLocalFolderAsync2 #501

merged 5 commits into from
Jun 9, 2024

Conversation

5saviahv
Copy link
Collaborator

@5saviahv 5saviahv commented Jun 9, 2024

added addLocalFolderAsync2

  • it uses node.js callback style
  • callback is last argument like most node.js functions do
  • idea is later replace addLocalFolderAsync witrh this
  • is internally more async than former
  • default disabled "namefix" what is always enabled in addLocalFolderAsync and wont let use names with not latin1 names

updated addLocalFolder

  • uses internally addLocalFile
  • is more consistent this way

added tests for updated functions & stream lined with other tests

@5saviahv 5saviahv merged commit a8ddc64 into cthackers:master Jun 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant