fix race-condition crash when extracting data and extracted files are (re)moved #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce you can extract a zip file with known contents while deleting the extracted files in a loop, e.g.
A zip file,
foo.zip
with the content:Then, in a shell run a loop that triggers this race condition:
In another shell, extract your files:
This will then crash and take your node process with it, because the file will have been removed between the
Utils.writeFileToAsync
andfs.utimesSync
calls.This PR fixes this bug and will return an error when this condition occurs.