Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stable split_once #116

Closed
jw3 opened this issue May 6, 2021 · 0 comments · Fixed by #117
Closed

Use stable split_once #116

jw3 opened this issue May 6, 2021 · 0 comments · Fixed by #117
Labels
debt Rust

Comments

@jw3
Copy link
Member

jw3 commented May 6, 2021

Waiting on Rust 1.52 to stabilize split_once for strings.

rust-lang/rust#74773

https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_once
@jw3 jw3 mentioned this issue May 6, 2021
Merged
@jw3 jw3 changed the title Remove custom impl of split_once Use stable split_once May 6, 2021
@jw3 jw3 closed this as completed in #117 May 7, 2021
jw3 added a commit that referenced this issue May 7, 2021
@jw3
Use stable str split_once (#117)
af0d590 
- use the now stable str `split_once`
- update workflow build bindings stage to use latest stable Rust

closes #116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use stable str split_once ctc-oss/fapolicy-analyzer
1 participant
@jw3