Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database.json #47

Merged
merged 1 commit into from
May 17, 2023
Merged

Update database.json #47

merged 1 commit into from
May 17, 2023

Conversation

DannyKokkinos
Copy link
Contributor

Updated database.json to point towards the new mezzanine content for CAAC, CAAA and CAMC

Updated database.json to point towards the new mezzanine content for CAAC, CAAA and CAMC
@rbouqueau
Copy link
Collaborator

The PR in itself is ok.

FYI I curl randomly a mpd and I saw this:

    <SegmentTimeline>
     <S t="0" d="89150"/>
     <S d="94208" r="13"/>
     <S d="31938"/>
    </SegmentTimeline>

Does this pattern looks ok to you?

@DannyKokkinos
Copy link
Contributor Author

Yes that pattern is correct.

@rbouqueau
Copy link
Collaborator

@nicholas-fr Do you confirm it looks ok ?

Then we can merge.

@yanj-github
Copy link
Contributor

@rbouqueau can you kinldy help to merge this change please?

@rbouqueau rbouqueau merged commit 4ea3d0e into cta-wave:master May 17, 2023
@rbouqueau
Copy link
Collaborator

I merged it but your first segment duration is shorter than the other ones. This doesn't look good to me.

@nicholas-fr
Copy link

The current validation script does not yet support audio test vectors, and needs more work (also for video).
I would expect consistent segment durations, based on our past discussions and validation of video test vectors.

Have these new test vectors at least passed JCCP validation?
I believe we had agreed that passing JCCP validation (or having bugs logged for any issues) was an acceptance criteria for new test content.

@haudiobe
Copy link
Member

As discussed in the DPCTF call, it would be great to attach JCCP test reports with submitted material. Can we establish such a process?

@michael-forsyth
Copy link

Concerning the segment lengths.

The aac codecs add padding to the start of the audio.
This is compensated for by an editlist box in the init segment informing the player to skip the padding during playback.
This means the encoded and playback duration are different for the audio.
As the fragmentation and segmentation is based on the encoded duration this results in the first segment having a shorter playback duration as shown in the MPD when the encoded duration of each segment is constant.
Therefore the first segment being shorter in the MPD by an amount equal to the padding is expected.

@rbouqueau
Copy link
Collaborator

As the fragmentation and segmentation is based on the encoded duration this results in the first segment having a shorter playback duration

Well it is based on whatever the muxing implementation does. I checked for GPAC and we changed the behaviour last December following a request from Fraunhofer for MPEG-H.

I don't think that was correct for older codecs. We discussed. And the old behaviour is back for most codecs.

Both results are correct. But if the validation script expects "consistent segment durations" (as @nicholas-fr said) we should consider regenerating.

@nicholas-fr
Copy link

Both results are correct. But if the validation script expects "consistent segment durations" (as @nicholas-fr said) we should consider regenerating.

I can adapt the validation script as needed. I anyway need to add proper support for the audio test streams.

@yanj-github
Copy link
Contributor

Thanks @nicholas-fr where is the validation script shared please? Is it on github yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants