-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update database.json #47
Conversation
Updated database.json to point towards the new mezzanine content for CAAC, CAAA and CAMC
The PR in itself is ok. FYI I curl randomly a mpd and I saw this:
Does this pattern looks ok to you? |
Yes that pattern is correct. |
@nicholas-fr Do you confirm it looks ok ? Then we can merge. |
@rbouqueau can you kinldy help to merge this change please? |
I merged it but your first segment duration is shorter than the other ones. This doesn't look good to me. |
The current validation script does not yet support audio test vectors, and needs more work (also for video). Have these new test vectors at least passed JCCP validation? |
As discussed in the DPCTF call, it would be great to attach JCCP test reports with submitted material. Can we establish such a process? |
Concerning the segment lengths. The aac codecs add padding to the start of the audio. |
Well it is based on whatever the muxing implementation does. I checked for GPAC and we changed the behaviour last December following a request from Fraunhofer for MPEG-H. I don't think that was correct for older codecs. We discussed. And the old behaviour is back for most codecs. Both results are correct. But if the validation script expects "consistent segment durations" (as @nicholas-fr said) we should consider regenerating. |
I can adapt the validation script as needed. I anyway need to add proper support for the audio test streams. |
Thanks @nicholas-fr where is the validation script shared please? Is it on github yet? |
Updated database.json to point towards the new mezzanine content for CAAC, CAAA and CAMC