Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better event header #22

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Better event header #22

merged 2 commits into from
Oct 28, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 28, 2022

This reduces the duplicated amount of field definitions for the different corsika versions by building on previous definitions.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 96.09% // Head: 96.47% // Increases project coverage by +0.37% 🎉

Coverage data is based on head (4b17291) compared to base (122ce4e).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   96.09%   96.47%   +0.37%     
==========================================
  Files          19       19              
  Lines         384      425      +41     
==========================================
+ Hits          369      410      +41     
  Misses         15       15              
Impacted Files Coverage Δ
corsikaio/subblocks/event_header.py 92.00% <90.00%> (+5.33%) ⬆️
corsikaio/file.py 97.91% <0.00%> (+0.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxnoe maxnoe requested a review from orelgueta October 28, 2022 15:13
Copy link
Contributor

@orelgueta orelgueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a simplification

@orelgueta orelgueta merged commit 6d7096d into main Oct 28, 2022
@maxnoe maxnoe deleted the better_event_header branch October 28, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants