-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CameraFrame-to-TelescopeFrame transformation and HillasReconstructor #151
Update CameraFrame-to-TelescopeFrame transformation and HillasReconstructor #151
Conversation
few modifications to account for limited data writing capabilities
details: - updated class for updated hillas reconstructor - added ignore warning for missing attribute frame - fixed debug print
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 66.25% 66.85% +0.59%
==========================================
Files 24 24
Lines 2291 2359 +68
==========================================
+ Hits 1518 1577 +59
- Misses 773 782 +9
Continue to review full report at Codecov.
|
Can you explain what the bug was? It is hard to tell with all the changes. |
My best guess is that it was some code divergence in the camera transformation part between the old development code in |
I mainly ask because the code to do the H_max reconstruction did not change, but what did change was perhaps the HillasPlane initialization. If H_max was wrong before, it is also possible there were other bugs (or new ones) that are fixed (or broken) in this new version since the direction and core reconstruction also depend on the HillasPlane definition. Therefore it would be nice to see what was the original problem that caused h_max to be incorrect so we don't repeat it, or so we can add a unit test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve it so we can try a full production, but would still like to undertstand what was fixed
No need to approve and merge the PR yet, I can just use it from a dev branch (I should have opened it as a draft PR sorry) |
Closes #149
One of the improvements seems to be at least the H_max estimation.
Line 1 protopipe before this PR 1 simtel run
Line 2 protopipe after this PR 1 simtel run
Line 3 CTAMARS full gamma1 sample
Update
Latest result using full
gamma1
sample