Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply CALIB_SCALE directly from ctapipe.io.SimtelEventSource #145

Merged
merged 13 commits into from
Jul 7, 2021

Conversation

HealthyPear
Copy link
Member

This PR basically implements what is currently pending in cta-observatory/ctapipe#1749

@HealthyPear HealthyPear added enhancement New feature or request DL1a labels Jun 16, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #145 (d871baf) into master (513e1ca) will increase coverage by 1.23%.
The diff coverage is 98.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   65.69%   66.93%   +1.23%     
==========================================
  Files          23       23              
  Lines        2169     2238      +69     
==========================================
+ Hits         1425     1498      +73     
+ Misses        744      740       -4     
Impacted Files Coverage Δ
protopipe/pipeline/temp.py 89.62% <98.46%> (+8.20%) ⬆️
protopipe/pipeline/event_preparer.py 65.96% <100.00%> (+1.08%) ⬆️
protopipe/scripts/data_training.py 93.05% <100.00%> (+0.13%) ⬆️
protopipe/scripts/write_dl2.py 81.96% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 513e1ca...d871baf. Read the comment docs.

@HealthyPear HealthyPear changed the title Add new version of CALIB_SCALE Apply CALIB_SCALE directly from ctapipe.io.SimtelEventSource Jun 16, 2021
protopipe/pipeline/temp.py Show resolved Hide resolved
protopipe/scripts/data_training.py Outdated Show resolved Hide resolved
@HealthyPear HealthyPear requested a review from kosack June 22, 2021 09:52
protopipe/pipeline/temp.py Show resolved Hide resolved
kosack
kosack previously approved these changes Jul 7, 2021
@HealthyPear HealthyPear merged commit bc24635 into master Jul 7, 2021
@HealthyPear HealthyPear deleted the add_calibscale branch July 7, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DL1a enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants