improvement of the waveforms and charge extraction #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 11, 2023 11:29
before trying to load cookies
loading all the data in memory -> to evoid ram excess usage -split computation of charge to finally merge
data fits.fz files
guillaumegrolleron
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
=========================================
- Coverage 0.39% 0.38% -0.01%
=========================================
Files 30 30
Lines 3275 3350 +75
=========================================
Hits 13 13
- Misses 3262 3337 +75
☔ View full report in Codecov by Sentry. |
added 2 commits
May 16, 2023 21:36
jlenain
approved these changes
May 24, 2023
jlenain
approved these changes
May 24, 2023
src/nectarchain/user_scripts/ggrolleron/load_wfs_compute_charge.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The small PR aims to improve the waveforms and charge extraction in the container module.
-The RAM needed to extract waveforms and charge was to much large for raw data with more than 50000 events. This PR solved this issue by using the
ChargeContainersandWaveformsContainersclass. Indeed now it is possible to extract waveforms and compute charge treating the fits.fz files one by one. It is quite transparent from outside of the module.-The script
load_wfs_compute_charge.pyhas been improved to take care of this modifications.-I aslo fixed a bug concerning the charge extraction, code was mixing the charge extracted and the peak index which was leading to inconsistent data
Basically now the memory usage stay hold back to 20 Gb when it reached 60 Gb before.