Adapt core code to support EvB v6 data format

[jlenain]

This PR should fix #118 , and cleaned the code via pre-commit hooks.
Most notably, the main changes can be found at:

• main...jlenain:nectarchain:EvBv6#diff-bacb4245fa958219e1c8aa49c2c3cd424237971b1f3c38842c7f159199996c09L57
• main...jlenain:nectarchain:EvBv6#diff-bacb4245fa958219e1c8aa49c2c3cd424237971b1f3c38842c7f159199996c09L114
• main...jlenain:nectarchain:EvBv6#diff-a2d042ce6bd5c27cf71e7c8b94e5aa65684a5a8bc84c27180be44822d1de7326L313

[tibaldo]

Thanks @jlenain, looks good to me! Is there already a test using v6 data or should we add one to make sure we don't make any mistakes around this point in the future?

[jlenain]

Thanks @jlenain, looks good to me! Is there already a test using v6 data or should we add one to make sure we don't make any mistakes around this point in the future?

Hi @tibaldo , thanks a lot, you're absolutely right. We recently introduced them in ctapipe_io_nectarcam, I will try to implement some shortly here.

[jlenain]

@tibaldo , at the moment, there is only one series of tests using a test run, in test_pedestal_tool.py. I'll try to add tests for the test run 5288 which is available on cccta-dataserver. When you implemented test_pedestal_tool.py, I guess the expected UCTS time stamps were frozen to values obtained when running it locally, is that correct ?

[tibaldo]

@jlenain yes, correct

[frnbrun]

Thanks, @jlenain ! This looks good. As discussed with @vmarandon, a possible improvement would be to call the nectarcam_service container of ctapipe_io_nectarcam to get rid of the try/except for loading the camera_config variables

[jlenain]

Thanks, @jlenain ! This looks good. As discussed with @vmarandon, a possible improvement would be to call the nectarcam_service container of ctapipe_io_nectarcam to get rid of the try/except for loading the camera_config variables

Thanks for the suggestion, @frnbrun , @vmarandon ! This is done in the last commit.

[jlenain]

Hi @frnbrun ,
I rebased the branch of this PR against main, to benefit from #125 , such that the CI tests do not fail.
This PR should be good to be merged.

[frnbrun]

Thanks!