Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to be able to not add IRF to DL3 files #94

Closed
wants to merge 3 commits into from

Conversation

morcuended
Copy link
Member

@morcuended morcuended commented Jan 31, 2022

In case we want to add IRF to DL3 later on. See discussion in #81.

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #94 (939fe36) into main (1599444) will increase coverage by 0.18%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   81.92%   82.11%   +0.18%     
==========================================
  Files          43       45       +2     
  Lines        4443     4579     +136     
==========================================
+ Hits         3640     3760     +120     
- Misses        803      819      +16     
Impacted Files Coverage Δ
osa/workflow/dl3.py 87.20% <91.66%> (ø)
osa/workflow/tests/test_dl3.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1599444...939fe36. Read the comment docs.

@morcuended
Copy link
Member Author

It turned out that the IRF-less DL3 files scheme is not viable (#81). Closing this

@morcuended morcuended closed this Jan 31, 2022
@morcuended morcuended deleted the dl3_no_irf branch January 31, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant