Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch lstchain_cherenkov_transparency.py script as a new step of closer #271

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

marialainez
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (41e7313) 81.85% compared to head (930f713) 81.78%.

Files Patch % Lines
src/osa/scripts/closer.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   81.85%   81.78%   -0.07%     
==========================================
  Files          57       57              
  Lines        4822     4837      +15     
==========================================
+ Hits         3947     3956       +9     
- Misses        875      881       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just try to implement the job dependency

src/osa/scripts/closer.py Outdated Show resolved Hide resolved
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should work like this

@morcuended
Copy link
Member

Test is failing because the expected command in it does not contain the --parsable. Please add it to the expected command.

@morcuended morcuended merged commit 490b902 into main Feb 6, 2024
5 of 7 checks passed
@morcuended morcuended deleted the add_cherenkov_transparency branch February 6, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants