Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check state of the jobs launched by autocloser #269

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Conversation

marialainez
Copy link
Collaborator

@marialainez marialainez commented Jan 16, 2024

Check that all the jobs launched by autocloser finished correctly before creating the NightFinished.txt file. See issue #263

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (41e7313) 81.85% compared to head (228d315) 81.72%.
Report is 9 commits behind head on main.

Files Patch % Lines
src/osa/scripts/closer.py 62.50% 6 Missing ⚠️
src/osa/job.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   81.85%   81.72%   -0.14%     
==========================================
  Files          57       57              
  Lines        4822     4864      +42     
==========================================
+ Hits         3947     3975      +28     
- Misses        875      889      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/osa/job.py Outdated Show resolved Hide resolved
src/osa/scripts/closer.py Show resolved Hide resolved
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go ahead with this, but keep in mind that cronjob frequency should change accordingly, with these changes the autocloser could be running up to 1 h checking for job proper completion.

@morcuended morcuended merged commit 56f3a0b into main Feb 13, 2024
4 of 7 checks passed
@morcuended morcuended deleted the check-closer branch February 13, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants