Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create the DL2 directory if --no-dl2 option is given #266

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

marialainez
Copy link
Collaborator

@marialainez marialainez commented Dec 15, 2023

I also moved the "dl1_datacheck" provenance lines to the DL1 directory, instead of being in DL2.

@morcuended morcuended linked an issue Jan 11, 2024 that may be closed by this pull request
@morcuended
Copy link
Member

Thanks @marialainez, I would move also "dl1_datacheck" to "r0_to_dl1" key in parse_lines_log:

cuts = {
        "calibration": ["drs4_pedestal", "calibrate_charge"],
        "r0_to_dl1": ["r0_to_dl1", "dl1ab"],
        "dl1_to_dl2": ["dl1_datacheck", "dl1_to_dl2"],
    }

@morcuended
Copy link
Member

Can you also update the branch with the current main so tests are triggered again?

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e2e2ad0) 81.80% compared to head (18c5637) 81.79%.

Files Patch % Lines
src/osa/scripts/provprocess.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   81.80%   81.79%   -0.02%     
==========================================
  Files          57       57              
  Lines        4820     4822       +2     
==========================================
+ Hits         3943     3944       +1     
- Misses        877      878       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morcuended morcuended merged commit 41e7313 into main Jan 12, 2024
5 of 7 checks passed
@morcuended morcuended deleted the prov-dl2 branch January 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DL2 directory still being created by autocloser
2 participants