Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gain selection to OSA workflow #230

Merged
merged 37 commits into from
Mar 12, 2024
Merged

Add gain selection to OSA workflow #230

merged 37 commits into from
Mar 12, 2024

Conversation

marialainez
Copy link
Collaborator

@marialainez marialainez commented Jun 16, 2023

Related to #227

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Attention: Patch coverage is 43.54839% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 79.70%. Comparing base (5eb79d5) to head (e4e6d3d).
Report is 15 commits behind head on main.

Files Patch % Lines
src/osa/scripts/gain_selection.py 24.71% 67 Missing ⚠️
src/osa/scripts/sequencer.py 81.81% 2 Missing ⚠️
src/osa/scripts/autocloser.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   82.06%   79.70%   -2.37%     
==========================================
  Files          57       59       +2     
  Lines        4885     5144     +259     
==========================================
+ Hits         4009     4100      +91     
- Misses        876     1044     +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morcuended morcuended marked this pull request as draft October 21, 2023 18:22
@morcuended
Copy link
Member

follow-up on this PR, conflicts need to be solved

@moralejo
Copy link

follow-up on this PR, conflicts need to be solved

Anyway, current gain selection program will not work with the data taken since early July in ADHF format, right?

@morcuended
Copy link
Member

follow-up on this PR, conflicts need to be solved

Anyway, current gain selection program will not work with the data taken since early July in ADHF format, right?

Ah, you're right! Then I guess this will have to be updated with whichever new tool we develop for this.

@marialainez marialainez marked this pull request as ready for review February 22, 2024 15:37
@marialainez marialainez marked this pull request as draft February 27, 2024 13:08
@marialainez marialainez marked this pull request as ready for review February 27, 2024 14:49
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, if you have tested it also on actual data go ahead with the merging

src/osa/scripts/sequencer.py Show resolved Hide resolved
@morcuended morcuended merged commit e589deb into main Mar 12, 2024
4 of 7 checks passed
@morcuended morcuended deleted the add_gainsel branch March 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants