Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to lstchain v0.10.0 #211

Merged
merged 15 commits into from
Jun 20, 2023
Merged

Updates to lstchain v0.10.0 #211

merged 15 commits into from
Jun 20, 2023

Conversation

morcuended
Copy link
Member

@morcuended morcuended commented Feb 13, 2023

closes #206

  • Update version of dependencies
  • Use new drive log file naming

@morcuended
Copy link
Member Author

We should try to use python 3.11 to take advantage of the 10% speed-up it offers over previous versions.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@morcuended morcuended changed the title Updates to lstchain v0.10 ctapipe_io_lst v0.19 Updates to lstchain v0.10.0 Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -10.21 ⚠️

Comparison is base (0cc21dd) 81.62% compared to head (2b20b1c) 71.41%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #211       +/-   ##
===========================================
- Coverage   81.62%   71.41%   -10.21%     
===========================================
  Files          57       57               
  Lines        4799     4790        -9     
===========================================
- Hits         3917     3421      -496     
- Misses        882     1369      +487     
Impacted Files Coverage Δ
osa/utils/tests/test_utils.py 100.00% <ø> (ø)
osa/utils/utils.py 85.60% <ø> (-0.63%) ⬇️
osa/job.py 71.51% <50.00%> (-8.19%) ⬇️
osa/paths.py 88.79% <100.00%> (-0.10%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@morcuended
Copy link
Member Author

code coverage decrease to be checked, probably related to subprocesses in tests

@morcuended morcuended merged commit cb8af17 into main Jun 20, 2023
@morcuended morcuended deleted the lstchain010 branch June 20, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new drive pointing log files
2 participants