add a warning in case the considered run is not in the summary table #153
Conversation
osa/paths.py
Outdated
| date_string = summary_table[summary_table["run_id"] == run_id]["date"][0] | ||
| except IndexError: | ||
| log.warning(f"Run {str(run_id)} is not in the summary table. Assuming the date of the run is {options.date}.") | ||
| date_string = options.date |
There was a problem hiding this comment.
I think that options.date is now a datetime object, so I'm not sure whether you can simply use the replace method for strings. Let's see if tests pass.
|
You have to remove the expected failing test as well since now we assume that the date would be with pytest.raises(IndexError):
get_run_date(1200)Also related to the |
|
remove also the unused import pytest (pyflakes is complaining) |
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
=======================================
Coverage 82.39% 82.40%
=======================================
Files 52 52
Lines 4635 4637 +2
=======================================
+ Hits 3819 3821 +2
Misses 816 816
Continue to review full report at Codecov.
|
|
I think this is ready @marialainez |
No description provided.