Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlockNectarCAMEventSource class #60

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vmarandon
Copy link
Contributor

Will read the data per block instead of all the files together. This remove the limitation of long acquisition that consume too much memory and reach quickly the limit of opened file.

The grouping of the blocks is 4 by default and correspond to the number of data stream of the acquisition.

There is also option to only read a certain set of blocks

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 13.82114% with 106 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (60533fe) to head (85a98a5).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
src/ctapipe_io_nectarcam/__init__.py 13.82% 106 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #60       +/-   ##
===========================================
- Coverage   88.75%   78.46%   -10.29%     
===========================================
  Files           7        7               
  Lines         685      915      +230     
===========================================
+ Hits          608      718      +110     
- Misses         77      197      +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlenain
Copy link
Contributor

jlenain commented Oct 8, 2024

Hi @vmarandon !

Thanks a lot for that!

It would be good indeed if the new class BlockNectarCAMEventSource could inherit from NectarCAMEventSource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants