Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More ImPACT code cleanup #2705

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

gschwefer
Copy link
Contributor

Hi everyone,

I finally got around to clean up the ImPACT code a bit more.

This PR has 3 major changes:

  • The paths to the input templates are now TelescopeParameters. I also changed the required structure of the templates, they now need to contain a new key tel_type which contains the telescope description as a string to check if they are valid for the telescope they are being used for. This will require a little fix to all currently existing templates, but it is an easy and quick one.
  • The pedestal and spe width parameters are now also TelescopeParameters. For the pedestal_width, I also included the option to read them from the monitoring. In case no values are specified, they fall back to a hardcoded value in a global dict.
  • Finally, for the tests, I removed the need for the dummy_reconstructor option/variable

I look forward to your comments and to discussion on the implementation of these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant