Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit cast necessary in numpy >=2.1 #2682

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Add explicit cast necessary in numpy >=2.1 #2682

merged 3 commits into from
Jan 20, 2025

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jan 20, 2025

No description provided.

kosack
kosack previously approved these changes Jan 20, 2025
@maxnoe
Copy link
Member Author

maxnoe commented Jan 20, 2025

Sorry @kosack, needed to also include the change from #2681 to have green CI

@kosack
Copy link
Contributor

kosack commented Jan 20, 2025

Now I think you overwrote the numpy changes?

@maxnoe
Copy link
Member Author

maxnoe commented Jan 20, 2025

Rebase gone wrong, fixed thanks to git reflog

This comment has been minimized.

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (94.10% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

@maxnoe maxnoe merged commit 1372299 into main Jan 20, 2025
13 checks passed
@maxnoe maxnoe deleted the fix_pixel_status branch January 20, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants