Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calibration calculators #2609

Open
wants to merge 111 commits into
base: main
Choose a base branch
from
Open

Add calibration calculators #2609

wants to merge 111 commits into from

Commits on Apr 29, 2024

  1. added stats extractor parent component

    added PlainExtractor based on numpy and scipy functions
    Tjark Miener authored and Tjark Miener committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    58d868c View commit details
    Browse the repository at this point in the history
  2. added stats extractor based on sigma clipping

    Tjark Miener authored and Tjark Miener committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    edfccc6 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. added cut of outliers

    restructured the stats containers
    Tjark Miener authored and Tjark Miener committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d19168c View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. update docs

    Tjark Miener committed May 2, 2024
    Configuration menu
    Copy the full SHA
    49f0f8a View commit details
    Browse the repository at this point in the history
  2. formatted with black

    Tjark Miener committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9035fb4 View commit details
    Browse the repository at this point in the history
  3. added pass for __call__ function

    Tjark Miener committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8a0e89f View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. added unit tests

    Tjark Miener authored and Tjark Miener committed May 3, 2024
    Configuration menu
    Copy the full SHA
    82b29e9 View commit details
    Browse the repository at this point in the history
  2. added changelog

    Tjark Miener authored and Tjark Miener committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1805cb2 View commit details
    Browse the repository at this point in the history
  3. fix lint

    Tjark Miener authored and Tjark Miener committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a4cea6a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Small commit for prototyping

    Christoph Toennis committed May 7, 2024
    Configuration menu
    Copy the full SHA
    16e5920 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Removed unneeded functions

    Christoph Toennis committed May 10, 2024
    Configuration menu
    Copy the full SHA
    63d1774 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'stats_extractor' of https://github.com/cta-observatory/…

    …ctapipe into stats_extractor
    Christoph Toennis committed May 23, 2024
    Configuration menu
    Copy the full SHA
    5768ed7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e6ba177 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. added a container for mean variance images and fixed docustring

    Christoph Toennis committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ddf342b View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. I changed the container type for the StarVarianceExtractor

    Christoph Toennis committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0beb975 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. fix pylint

    Remove StarVarianceExtractor since is functionality is featured in the existing Extractors
    Tjark Miener authored and Tjark Miener committed May 31, 2024
    Configuration menu
    Copy the full SHA
    b4df919 View commit details
    Browse the repository at this point in the history
  2. change __call__() to _extract()

    Tjark Miener authored and Tjark Miener committed May 31, 2024
    Configuration menu
    Copy the full SHA
    3483fd4 View commit details
    Browse the repository at this point in the history
  3. minor renaming

    Tjark Miener authored and Tjark Miener committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5bbedda View commit details
    Browse the repository at this point in the history
  4. use pytest.fixture for Extractors

    Tjark Miener authored and Tjark Miener committed May 31, 2024
    Configuration menu
    Copy the full SHA
    14a0910 View commit details
    Browse the repository at this point in the history
  5. reduce duplicated code of the call function

    Tjark Miener authored and Tjark Miener committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f126748 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Configuration menu
    Copy the full SHA
    0ec81b9 View commit details
    Browse the repository at this point in the history
  2. added feature to shift the extraction sequence

    allow overlapping extraction sequences
    TjarkMiener committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3910c22 View commit details
    Browse the repository at this point in the history
  3. fix boundary case for the last chunk

    renaming to chunk(s) and chunk_size and _shift
    
    added test for chunk_shift and boundary case
    TjarkMiener committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    5c6595b View commit details
    Browse the repository at this point in the history
  4. I made prototypes for the CalibrationCalculators

    Christoph Toennis committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    bc65984 View commit details
    Browse the repository at this point in the history
  5. I made PSFModel a generic class

    Christoph Toennis committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    d7a65a3 View commit details
    Browse the repository at this point in the history
  6. fix tests

    TjarkMiener committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ba00bf3 View commit details
    Browse the repository at this point in the history
  7. fix ruff

    TjarkMiener committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    d3aae32 View commit details
    Browse the repository at this point in the history
  8. I fixed some variable names

    Christoph Toennis committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    825b25b View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Added a method for calibrating variance images

    Christoph Toennis committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a5b878d View commit details
    Browse the repository at this point in the history
  2. Merge branch 'stats_extractor' into CalibrationCalculators

    Christoph Toennis committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    e8ebdd8 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Commit before push for tjark

    Christoph Toennis committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    78481cc View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    41a4246 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. make faulty_pixels_threshold and chunk_shift as traits

    rename stats calculator to TwoPass...
    TjarkMiener committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    010aea6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. added stats extractor parent component

    added PlainExtractor based on numpy and scipy functions
    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    26ff8a4 View commit details
    Browse the repository at this point in the history
  2. added stats extractor based on sigma clipping

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d142995 View commit details
    Browse the repository at this point in the history
  3. added cut of outliers

    restructured the stats containers
    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0737b7f View commit details
    Browse the repository at this point in the history
  4. update docs

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    225346b View commit details
    Browse the repository at this point in the history
  5. formatted with black

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    74c72bb View commit details
    Browse the repository at this point in the history
  6. added pass for __call__ function

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    faad542 View commit details
    Browse the repository at this point in the history
  7. Small commit for prototyping

    Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9867431 View commit details
    Browse the repository at this point in the history
  8. Removed unneeded functions

    Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    3a85ffa View commit details
    Browse the repository at this point in the history
  9. added unit tests

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    69ebd1c View commit details
    Browse the repository at this point in the history
  10. added changelog

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    96b2dbb View commit details
    Browse the repository at this point in the history
  11. fix lint

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a007773 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    96fe563 View commit details
    Browse the repository at this point in the history
  13. added a container for mean variance images and fixed docustring

    Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    67d34c4 View commit details
    Browse the repository at this point in the history
  14. I changed the container type for the StarVarianceExtractor

    Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f1429da View commit details
    Browse the repository at this point in the history
  15. fix pylint

    Remove StarVarianceExtractor since is functionality is featured in the existing Extractors
    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c9ec02b View commit details
    Browse the repository at this point in the history
  16. change __call__() to _extract()

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    444e370 View commit details
    Browse the repository at this point in the history
  17. minor renaming

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1c4cadb View commit details
    Browse the repository at this point in the history
  18. use pytest.fixture for Extractors

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0ebb464 View commit details
    Browse the repository at this point in the history
  19. reduce duplicated code of the call function

    Tjark Miener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    bbbd891 View commit details
    Browse the repository at this point in the history
  20. I made prototypes for the CalibrationCalculators

    Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5deef74 View commit details
    Browse the repository at this point in the history
  21. I made PSFModel a generic class

    Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f09bbe1 View commit details
    Browse the repository at this point in the history
  22. I fixed some variable names

    Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b8f0a4f View commit details
    Browse the repository at this point in the history
  23. Added a method for calibrating variance images

    Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    39fca21 View commit details
    Browse the repository at this point in the history
  24. edit description of StatisticsContainer

    TjarkMiener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b114638 View commit details
    Browse the repository at this point in the history
  25. added feature to shift the extraction sequence

    allow overlapping extraction sequences
    TjarkMiener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5d18f61 View commit details
    Browse the repository at this point in the history
  26. fix boundary case for the last chunk

    renaming to chunk(s) and chunk_size and _shift
    
    added test for chunk_shift and boundary case
    TjarkMiener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4df8c94 View commit details
    Browse the repository at this point in the history
  27. fix tests

    TjarkMiener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    86eb15c View commit details
    Browse the repository at this point in the history
  28. fix ruff

    TjarkMiener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6200653 View commit details
    Browse the repository at this point in the history
  29. Commit before push for tjark

    Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4f604c5 View commit details
    Browse the repository at this point in the history
  30. added StatisticsCalculator

    TjarkMiener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6dfce15 View commit details
    Browse the repository at this point in the history
  31. make faulty_pixels_threshold and chunk_shift as traits

    rename stats calculator to TwoPass...
    TjarkMiener authored and Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8e873d3 View commit details
    Browse the repository at this point in the history
  32. Merge branch 'CalibrationCalculators' of https://github.com/cta-obser…

    …vatory/ctapipe into CalibrationCalculators
    Christoph Toennis committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    bf36b90 View commit details
    Browse the repository at this point in the history
  33. solved merge conflicts

    TjarkMiener committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f7d3223 View commit details
    Browse the repository at this point in the history
  34. I made prototypes for the CalibrationCalculators

    Christoph Toennis authored and TjarkMiener committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    91812da View commit details
    Browse the repository at this point in the history
  35. I made PSFModel a generic class

    Christoph Toennis authored and TjarkMiener committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    326c202 View commit details
    Browse the repository at this point in the history
  36. I fixed some variable names

    Christoph Toennis authored and TjarkMiener committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    fa029f7 View commit details
    Browse the repository at this point in the history
  37. Added a method for calibrating variance images

    Christoph Toennis authored and TjarkMiener committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    7c90e0f View commit details
    Browse the repository at this point in the history
  38. Commit before push for tjark

    Christoph Toennis authored and TjarkMiener committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8c44a42 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    bff611a View commit details
    Browse the repository at this point in the history
  40. make faulty_pixels_threshold and chunk_shift as traits

    rename stats calculator to TwoPass...
    TjarkMiener committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d85dd50 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. adding interpolator and Merge branch 'CalibrationCalculators' of http…

    …s://github.com/cta-observatory/ctapipe into CalibrationCalculators
    Christoph Toennis committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c522434 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Removed Pointing Calculator

    Christoph Toennis committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9192790 View commit details
    Browse the repository at this point in the history
  2. Removing PointingCalculator, PSF model and interpolators

    Christoph Toennis committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    aecc5dc View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Configuration menu
    Copy the full SHA
    e3113ab View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. removed the helper function to get the start and end slices

    Since agregation is chunk has always the same n_events, we can simplify the retrieving of the start and end slices. Therefore we do not need a helper function anymore
    TjarkMiener committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b9dc929 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. polish docstrings

    TjarkMiener committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    ef920da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9bfc16a View commit details
    Browse the repository at this point in the history
  3. fix typo

    TjarkMiener committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    aee5c10 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1484eca View commit details
    Browse the repository at this point in the history
  5. moved Interpolator outside

    This branch should only host the devs for the stats calculator
    TjarkMiener committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    601cbb4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0347153 View commit details
    Browse the repository at this point in the history
  7. removed reading part with TableLoader

    reading should be done in the tool outside of this component
    TjarkMiener committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    b2208d5 View commit details
    Browse the repository at this point in the history
  8. removed writing part

    writing should be also done in the tool outside of this component
    TjarkMiener committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    61936e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Configuration menu
    Copy the full SHA
    52ecd8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ffd39e View commit details
    Browse the repository at this point in the history
  3. split __call__ function into two function for the first and second pass

    second pass also has an argument to pass the list of faulty/valid chunks which can be a logical_and from multiple first passes
    TjarkMiener committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c404a4a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a59664e View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. removed check for any faulty chunk

    check should be done before and then the second pass should not be called if only valid chunks are provided
    TjarkMiener committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0ed515d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48c686b View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. fix fstring in logging

    TjarkMiener committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    3bae046 View commit details
    Browse the repository at this point in the history
  2. bug fix

    aggregated stats of the second pass we simply overwritten rather than append and vstacked()
    
    unit tests are improved to properly test for the correct number of chunks
    TjarkMiener committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    aa5666a View commit details
    Browse the repository at this point in the history
  3. removed print

    TjarkMiener committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ef53ebb View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    3ca7252 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    4af4e74 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Configuration menu
    Copy the full SHA
    1e684b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    0bd7702 View commit details
    Browse the repository at this point in the history
  2. rename n_pix to n_pixels

    TjarkMiener committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    83ee522 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a29808 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    55451d2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5b8ed0b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6e0d00a View commit details
    Browse the repository at this point in the history
  7. remove redundant import

    TjarkMiener committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    fea13eb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1a99eb4 View commit details
    Browse the repository at this point in the history
  9. polish docstrings

    TjarkMiener committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e8e7f37 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    bc4fac9 View commit details
    Browse the repository at this point in the history
  11. fix ruff formatting

    TjarkMiener committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    88977ed View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    9a0914d View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. rename faulty_pixels_threshold to faulty_pixels_fraction

    polish doctrings for trait help
    TjarkMiener committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f300846 View commit details
    Browse the repository at this point in the history