-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setuptools_scm for versioning, fixes #1333 #1334
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
==========================================
+ Coverage 90.78% 90.97% +0.19%
==========================================
Files 188 189 +1
Lines 13562 13510 -52
==========================================
- Hits 12312 12291 -21
+ Misses 1250 1219 -31
Continue to review full report at Codecov.
|
please add a PR description of what this solves |
could you merge in the master and fix conflicts? I'll take a look at this soon |
4ec45a1
to
fdd8701
Compare
@kosack I rechecked with the last astropy issues/PRs and implemented what they do, which makes sense I think.
|
Ah, we could also think about uploading the sdist using the github releases plugin for pypi, so we have a functioning tarball on github (but just using pypi / conda is also fine I think) |
No description provided.