-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EventSource.from_config
#2258
Comments
I didn't even realize it existed! Yes, should remove |
Not sure if this is the right place, but the docs are a bit obscure about this part. They mention that "An EventSource can also be created through the configuration system" which sounds clear, but than they mention both Is it possible to add more lines about this and what is the difference? config should be a dictionary loaded with the traitlets API, but what's parent? |
It comes from the
The constructors are overloaded to support all three methods, but generally you should not mix them. E.g. if you specify |
Remove EventSource.from_config, fixes #2258
Please describe the use case that requires this feature.
EventSource.from_config
is not needed anymore (and since quite some time), sinceEventSource(parent=self)
"just works™".@FrancaCassol was confused about what the purpose is. Since it doesn't serve one anymore, we should remove that method.
The text was updated successfully, but these errors were encountered: