Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Subarray info in output DL1 files #1347

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

moralejo
Copy link
Collaborator

@moralejo moralejo commented Feb 4, 2025

If an outdated Subarray info is found in input file, it is not propagated to the output. A new one is created and saved instead.
This makes that even for v0.9 DL1 input files, the output DL1 file contains v0.10-compliant Subarray info.

propagated to the output. A new one is created and saved instead.
@moralejo moralejo requested a review from rlopezcoto February 4, 2025 21:28
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.86%. Comparing base (5f490a4) to head (a0cf23a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lstchain/scripts/lstchain_dl1ab.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
- Coverage   72.87%   72.86%   -0.01%     
==========================================
  Files         137      137              
  Lines       14511    14515       +4     
==========================================
+ Hits        10575    10577       +2     
- Misses       3936     3938       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moralejo moralejo merged commit 76540cc into main Feb 5, 2025
6 of 8 checks passed
@moralejo moralejo deleted the dl1b_subarray_description branch February 5, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants