Rename secret key to 'token'

csp33 · Sep 14, 2024 · eb49733 · eb49733
1 parent d362c7f
commit eb49733
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -44,7 +44,7 @@ helm uninstall cert-manager-duckdns-webhook
 ### Pushing the image
 
 ```shell
-export IMAGE_TAG=1.0.0
+export IMAGE_TAG=1.0.1
 docker buildx build --push --platform linux/arm64,linux/amd64 -t csp33/cert-manager-duckdns-webhook:$IMAGE_TAG -t csp33/cert-manager-duckdns-webhook:latest .;
 ```
 

diff --git a/charts/cert-manager-duckdns-webhook/Chart.yaml b/charts/cert-manager-duckdns-webhook/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v1
 appVersion: "1.0"
 description: Helm Chart for the Cert Manager DuckDNS WebHook
 name: cert-manager-duckdns-webhook
-version: 1.1.2
+version: 1.1.3
 
 maintainers:
   - name: csp33
diff --git a/charts/cert-manager-duckdns-webhook/templates/token-secret.yaml b/charts/cert-manager-duckdns-webhook/templates/token-secret.yaml
@@ -11,6 +11,6 @@ metadata:
     heritage: {{ .Release.Service }}
 type: Opaque
 stringData:
-  api-token: "{{ $.Values.token.value}}"
+  token: "{{ $.Values.token.value}}"
 {{ end }}
 
diff --git a/charts/cert-manager-duckdns-webhook/values.yaml b/charts/cert-manager-duckdns-webhook/values.yaml
@@ -35,7 +35,7 @@ clusterIssuer:
 
 token:
   value: ~
-  existingSecretName: "" # Secret must have the token in the `api-token` key
+  existingSecretName: "" # Secret must have the token in the `token` key
 
 service:
   type: ClusterIP

diff --git a/src/config/config_test.go b/src/config/config_test.go
@@ -13,7 +13,7 @@ func TestLoadConfig_ValidConfig(t *testing.T) {
 		Raw: json.RawMessage(`{
 			"apiTokenSecretRef": {
 				"name": "my-secret",
-				"key": "api-token"
+				"key": "token"
 			}
 		}`),
 	}
@@ -22,15 +22,15 @@ func TestLoadConfig_ValidConfig(t *testing.T) {
 
 	assert.NoError(t, err, "Expected no error for valid config")
 	assert.Equal(t, "my-secret", cfg.APITokenSecretRef.LocalObjectReference.Name, "Expected API token secret name to match")
-	assert.Equal(t, "api-token", cfg.APITokenSecretRef.Key, "Expected API token secret key to match")
+	assert.Equal(t, "token", cfg.APITokenSecretRef.Key, "Expected API token secret key to match")
 }
 
 func TestLoadConfig_InvalidConfigName(t *testing.T) {
 	cfgJSON := &extapi.JSON{
 		Raw: json.RawMessage(`{
 			"apiTokenSecretRef": {
 				"name": "",
-				"key": "api-token"
+				"key": "token"
 			}
 		}`),
 	}

diff --git a/testdata.example/duckdns-solver/config.json b/testdata.example/duckdns-solver/config.json
@@ -1,6 +1,6 @@
 {
   "apiTokenSecretRef": {
     "name": "my-secret",
-    "key": "api-token"
+    "key": "token"
   }
 }
diff --git a/testdata.example/duckdns-solver/secret.yaml b/testdata.example/duckdns-solver/secret.yaml
@@ -3,4 +3,4 @@ kind: Secret
 metadata:
   name: my-secret
 stringData:
-  api-token: "DUCKDNS_TOKEN"
+  token: "DUCKDNS_TOKEN"