Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume group replication controller code #610

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha commented Jul 8, 2024

This PR adds the following codes/logic:

  • Added volume group replication controller logic
  • Added generated crds, rbacs
  • Added docs to create VGR, VGRClass and VGRContent CRs

@Nikhil-Ladha
Copy link
Contributor Author

Nikhil-Ladha commented Jul 8, 2024

The changes are not yet tested, will wait for #605 to get merged and then update a few things and test it.
In the meantime, please feel free to provide some initial reviews.
Thanks :)

@Nikhil-Ladha Nikhil-Ladha force-pushed the add-vgr-controller-us branch from f322110 to 10df032 Compare July 11, 2024 07:36
internal/proto/volumegroup.proto Outdated Show resolved Hide resolved
internal/proto/volumegroup.proto Outdated Show resolved Hide resolved
@Nikhil-Ladha Nikhil-Ladha force-pushed the add-vgr-controller-us branch from 10df032 to 15b901d Compare July 11, 2024 09:27
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to do few more rounds of review, just done it for few files

controllers/replication.storage/finalizers.go Outdated Show resolved Hide resolved
controllers/replication.storage/finalizers.go Outdated Show resolved Hide resolved
controllers/replication.storage/finalizers.go Outdated Show resolved Hide resolved
controllers/replication.storage/utils.go Outdated Show resolved Hide resolved
@Nikhil-Ladha Nikhil-Ladha force-pushed the add-vgr-controller-us branch from 15b901d to 6b05893 Compare July 12, 2024 12:02
@mergify mergify bot added the api Change to the API, requires extra care label Jul 12, 2024
@mergify mergify bot requested a review from ShyamsundarR July 12, 2024 12:02
@Nikhil-Ladha Nikhil-Ladha force-pushed the add-vgr-controller-us branch 7 times, most recently from 0121241 to 8e8830d Compare July 18, 2024 11:38
@mergify mergify bot added the vendor Pull requests that update vendored dependencies label Jul 18, 2024
@Nikhil-Ladha Nikhil-Ladha force-pushed the add-vgr-controller-us branch from 8e8830d to fbeb1a7 Compare July 19, 2024 10:13
Copy link
Collaborator

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add documentation with an example in the docs/ directory? That makes it easier to visualize how things are supposed to work.

@Nikhil-Ladha Nikhil-Ladha force-pushed the add-vgr-controller-us branch 10 times, most recently from 7d2176f to fdbc6b0 Compare December 4, 2024 08:40
@Nikhil-Ladha Nikhil-Ladha force-pushed the add-vgr-controller-us branch 15 times, most recently from d801d41 to 6d41212 Compare January 7, 2025 13:08
added controller logic for volume group replication

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
add generated changes for crds, rbacs

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
add docs for volumegroupreplication and volumegroupreplicationclass
CRs.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
@Nikhil-Ladha Nikhil-Ladha force-pushed the add-vgr-controller-us branch from 6d41212 to 6f239ca Compare January 9, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Change to the API, requires extra care vendor Pull requests that update vendored dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants