-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volume group replication controller code #610
base: main
Are you sure you want to change the base?
Conversation
The changes are not yet tested, will wait for #605 to get merged and then update a few things and test it. |
f322110
to
10df032
Compare
10df032
to
15b901d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still need to do few more rounds of review, just done it for few files
controllers/replication.storage/volumegroupreplication_controller.go
Outdated
Show resolved
Hide resolved
controllers/replication.storage/volumegroupreplication_controller.go
Outdated
Show resolved
Hide resolved
controllers/replication.storage/volumegroupreplication_controller.go
Outdated
Show resolved
Hide resolved
controllers/replication.storage/volumegroupreplication_controller.go
Outdated
Show resolved
Hide resolved
controllers/replication.storage/volumegroupreplication_controller.go
Outdated
Show resolved
Hide resolved
15b901d
to
6b05893
Compare
0121241
to
8e8830d
Compare
8e8830d
to
fbeb1a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add documentation with an example in the docs/
directory? That makes it easier to visualize how things are supposed to work.
4fd2e6a
to
66d017c
Compare
internal/controller/replication.storage/volumegroupreplication_controller.go
Show resolved
Hide resolved
internal/controller/replication.storage/volumegroupreplication_controller.go
Show resolved
Hide resolved
internal/controller/replication.storage/volumegroupreplicationcontent_controller.go
Show resolved
Hide resolved
7d2176f
to
fdbc6b0
Compare
fdbc6b0
to
34781d8
Compare
d801d41
to
6d41212
Compare
added controller logic for volume group replication Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
add generated changes for crds, rbacs Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
add docs for volumegroupreplication and volumegroupreplicationclass CRs. Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
6d41212
to
6f239ca
Compare
This PR adds the following codes/logic: