-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code for #292 #293
base: master
Are you sure you want to change the base?
Add code for #292 #293
Conversation
@Robinlovelace Nice additional, however, the code doesn't run for me. Also, what do you suggest about timing from vroom and lasy loading? |
Was just a starter for 10. What do you mean by 'timing for lazy loading'? Happy to iterate, just trying to get things up-to-date. Another idea: should we print package versions? I think the current benchmark results are pretty out-of-date... |
Source: https://www.tidyverse.org/blog/2019/05/vroom-1-0-0/ Cheers |
Makes sense. We could add that caveat to the text - that's a good starting point, especially as some char string variables are not used. Re the implementation, that's amazing. Does it mean that an object created by |
Worth documenting that and adding a link to the book I think, a very interested and fast implementation. |
I'm hoping to take a look at this a bit later in the week. I do agree to printing package versions though; I think it's a quick way to know if the benchmark is wildly out of date. |
Great, thanks @engineerchange. Any additions on top of this branch very welcome. |
No description provided.