HTTPServerBase: change Request to be more verbose respond_nohandler #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 4 4
Lines 601 601
=======================================
Hits 574 574
Misses 27 27 ☔ View full report in Codecov by Sentry. |
dublet
force-pushed
the
nohandler-longer-response
branch
2 times, most recently
from
9f9074f
to
a0207a0
Compare
When a Request is not handled and thus triggers the nohandler, it can be very useful to have a more verbose output to indicate which Request is unhandled.
dublet
force-pushed
the
nohandler-longer-response
branch
from
a0207a0
to
e09fbed
Compare
|
Thanks! LGTM! |
csernazs
added a commit
that referenced
this pull request
Feb 16, 2024
csernazs
added a commit
that referenced
this pull request
Feb 16, 2024
|
@dublet is it ok for you to have this released next week? I have released a version recently and I want to wait a bit. |
Yes, fine by me 👍 |
|
@dublet pytest 1.0.10 has been released to pypi with your commit, thanks again! For some reason the search on pypi is outdated for a few days but if you look at https://pypi.org/project/pytest_httpserver/ it will show the latest release as 1.0.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Request is not handled and thus triggers the nohandler, it can be very useful to have a more verbose output to indicate which Request is unhandled.
This is particularly useful when you are in a test cycle and trying to determine which requests is mismatching.