Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error by replacing method #3

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Fix error by replacing method #3

merged 2 commits into from
Jul 20, 2024

Conversation

smellilac
Copy link
Contributor

No description provided.

The Description and Experience properties are of type List<string>, t…
f736049 
…he previous method returned a string. Created a new method and replaced the previous one
csc530
csc530 requested changes Jul 19, 2024
View reviewed changes
Copy link
Owner

@csc530 csc530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the experience and description are non-nullable List<string> (not List<string>? so the orNull() should be removed to prevent exceptions.

thanks for the fix, the tests project is quite a mess and have gotten very out of sync of the commands😅

@smellilac
Copy link
Contributor Author

I apologize for my inattention 😥 Removed possible refund null

@smellilac smellilac requested a review from csc530 July 20, 2024 13:25
@csc530
Copy link
Owner

csc530 commented Jul 20, 2024

It's all good

@csc530 csc530 merged commit 3902c02 into csc530:main Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csc530 csc530 csc530 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smellilac @csc530