Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications #37

Closed
aleccool213 opened this issue Nov 4, 2014 · 5 comments
Closed

Notifications #37

aleccool213 opened this issue Nov 4, 2014 · 5 comments

Comments

@aleccool213
Copy link

As Max or Professor Sara, I want to receive notifications for my subscribed topics so that I don’t have to check for important updates all the time. [3] [A]

@ghost ghost self-assigned this Nov 5, 2014
ghost pushed a commit that referenced this issue Nov 12, 2014
@ghost
Copy link

ghost commented Nov 12, 2014

Email notifications have been implemented.

  • Added support for gmail smtp email.
    • Account: messageboard.notifications@gmail.com
    • Password: teammates8
    • This means that registration emails and subscription notifications will actually be sent to the user's email address. Please be prepared for this, heh. Also note that phishing filters and junk filters really really don't like our emails, so check around.
    • Currently enabled on this branch by default - to disable, uncomment the following line in settings.py (its at the bottom):
EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'
  • Support for a delay between email notifications
    • Default is currently 6 hours, defined in the default for notification_delay in UserProfile.
    • Currently no support for changing this from the user interface.
  • Support for a notification queue
    • When the delay for sending notifications has not yet passed, the topic is instead added to a queue, and will be included in the next notification email instead.
  • Emails are currently SYNCHRONOUS - there will be a slight delay between posting a message if a notification email is being sent out. Asynchronous tasks will probably require a third party package, so I'm going to leave it like this for now (maybe a good phase 3 task)

@ghost ghost added testing and removed implementing labels Nov 12, 2014
@ghost
Copy link

ghost commented Nov 12, 2014

On further thought, it may be fairly easy to do asynchronous emailing by using some client-side AJAX, but I'm not sure I'd be able to handle a situation where a message fails to post for any reason.

Dunno if it would be valid or worth the time to do. Of someone thinks its important to do for this phase, let me know.

@ghost
Copy link

ghost commented Nov 12, 2014

Hah, last minute realization: this will only work when posting a message on the actual topic page. I meant to add it to the table controller as well, but I completely forgot.

ghost pushed a commit that referenced this issue Nov 12, 2014
@ghost
Copy link

ghost commented Nov 12, 2014

Added support for posting messages from the table view, now good to go for testing.

@ghost ghost mentioned this issue Nov 12, 2014
ghost pushed a commit that referenced this issue Nov 13, 2014
@ghost
Copy link

ghost commented Nov 13, 2014

Appears to be working after testing.

@ghost ghost closed this as completed Nov 13, 2014
ghost pushed a commit that referenced this issue Dec 6, 2014
ghost pushed a commit that referenced this issue Dec 6, 2014
ghost pushed a commit that referenced this issue Dec 6, 2014
ghost pushed a commit that referenced this issue Jan 4, 2015
ghost pushed a commit that referenced this issue Jan 4, 2015
@ghost ghost removed their assignment Sep 24, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant