Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove peerDeps which are already enforced via Chakra UI itself #47

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Remove peerDeps which are already enforced via Chakra UI itself #47

merged 2 commits into from
Feb 8, 2022

Conversation

paescuj
Copy link
Contributor

@paescuj paescuj commented Feb 7, 2022

v6 of framer-motion contains no breaking change which affects chakra-react-select, see https://github.com/framer/motion/blob/main/CHANGELOG.md#600-2022-01-19

Chakra UI itself has also updated the peer dependency recently: chakra-ui/chakra-ui#5499

@csandman
Copy link
Owner

csandman commented Feb 7, 2022

Thanks for the PR! I had been waiting for Chakra to update that dep before I made my move to update.

However, I have been thinking that including chakra's peerDeps in this package's peerDeps is generally overkill as npm will already get mad at you for not including the proper versions that chakra itself requires.

So I will approve this PR if you change it by removing the peer dependencies for @emotion/react, @emotion/styled, and framer-motion completely.

@csandman csandman self-requested a review February 8, 2022 02:59
@paescuj
Copy link
Contributor Author

paescuj commented Feb 8, 2022

Thanks for your review, @csandman! Actually, I was thinking the same 😄 This makes total sense and I've updated the PR accordingly 👍

@paescuj paescuj changed the title Allow framer-motion v6 Remove peerDeps which are already enforced via Chakra UI itself Feb 8, 2022
@csandman csandman merged commit 44b2ddf into csandman:main Feb 8, 2022
@paescuj paescuj deleted the allow-framer-motion-v6 branch February 8, 2022 18:03
@csandman
Copy link
Owner

csandman commented Feb 8, 2022

Approved and merged, thanks for the PR! You'll see this change in 3.0.4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants