fix: Fix react-select
core Props
type export
#324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After my previous change to switch to
tsup
for building the project, I had to do a lot of shifting types around to ensure the module augmentation to add the custom props was still working properly. However, I realized that after doing so I ended up exporting the coreProps
type fromreact-select/base
instead of justreact-select
. These do not have an identical type definition as the props that are normally exported, and thus can't be used to define props external to a select component in the same way.To fix this, I stopped exporting the props, and switched my main import for these base props:
to an export:
based on this comment: JedWatson/react-select#5762 (comment)
I still don't fully understand what the end result of all of this is, but I do know that it now works!