-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix module augmentation and install latest version of react-select
again
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3e74e23:
|
📊 Package size report 0.1%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
This is great news for ESM projects, thank you! |
This was
linked to
issues
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part two to #284 in which I fixed the broken module augmentation for projects using TypeScript with
moduleResolution="bundler"
. I finally got some replies on my PR to the react select project: JedWatson/react-select#5762 (comment)And the maintainers basically explained that the method for implementing the module augmentation in the docs was outdated. The new approach is to augment them from the higher level (and already public) package
react-select/base
:Here is an example project with broken module augmentation in
v4.7.2
, before I pushed a temporary fix that downgraded React Select's version tov5.7.0
: https://codesandbox.io/s/323lhc?file=/app.tsxYou can see the working version generated below.