Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make appviewurl default to appurl #46

Merged
merged 1 commit into from
Aug 31, 2021
Merged

make appviewurl default to appurl #46

merged 1 commit into from
Aug 31, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek
Copy link
Contributor Author

@glpatcern is this the right fix? at least the function signature suggests that: string appviewurl (optional): the URL of the end-user application in view mode when different (defaults to appurl)

@wkloucek wkloucek marked this pull request as ready for review August 31, 2021 13:10
@wkloucek wkloucek mentioned this pull request Aug 31, 2021
Merged
glpatcern
glpatcern approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch!

@glpatcern glpatcern merged commit aac0084 into cs3org:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @glpatcern