Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cs3: fixed lock and error handling on writefile #139

Merged
merged 7 commits into from
Mar 7, 2024
Merged

cs3: fixed lock and error handling on writefile #139

merged 7 commits into from
Mar 7, 2024

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Nov 28, 2023 •
edited
Loading

Fixes #137

@glpatcern glpatcern requested a review from javfg as a code owner November 28, 2023 14:26
@glpatcern glpatcern changed the title cs3: fixed lock and error handling on writefile, closes #137 cs3: fixed lock and error handling on writefile Nov 28, 2023
@glpatcern glpatcern linked an issue Nov 28, 2023 that may be closed by this pull request
writefile in cs3 interface does not properly support locking #137
Closed
@glpatcern glpatcern force-pushed the fix-writefile-lock branch 2 times, most recently from df8f53f to 49ada73 Compare December 4, 2023 10:49
@glpatcern glpatcern requested a review from wkloucek December 4, 2023 10:50
@glpatcern glpatcern force-pushed the fix-writefile-lock branch 3 times, most recently from e8d35df to 0853ff8 Compare January 19, 2024 10:00
@glpatcern glpatcern removed the request for review from javfg January 22, 2024 13:04
@glpatcern glpatcern mentioned this pull request Feb 13, 2024
Merged
@glpatcern
Copy link
Member Author

@wkloucek as I see you're willing to test this, and as in parallel I'm working on Reva to honor the locks on write, I realized that we could simplify the workflow a bit and pass the lock metadata on the actual PUT (see cs3org/cs3apis#226). This is the reason for the last commit. Clearly we have to agree on the headers to use...

@wkloucek
Copy link
Contributor

@wkloucek as I see you're willing to test this, and as in parallel I'm working on Reva to honor the locks on write, I realized that we could simplify the workflow a bit and pass the lock metadata on the actual PUT (see cs3org/cs3apis#226). This is the reason for the last commit. Clearly we have to agree on the headers to use...

@glpatcern thanks for pinging me! I'm currently not working on WOPI topics, but @jvillafanez / @micbar probably can a look

@glpatcern glpatcern mentioned this pull request Feb 15, 2024
Merged
@glpatcern glpatcern force-pushed the fix-writefile-lock branch 2 times, most recently from b7af6ac to 85f8faf Compare February 15, 2024 08:50
@glpatcern glpatcern force-pushed the fix-writefile-lock branch 6 times, most recently from b692397 to a2f2fd4 Compare March 1, 2024 16:44
@glpatcern glpatcern force-pushed the fix-writefile-lock branch from a2f2fd4 to 7fc5f64 Compare March 4, 2024 14:48
@glpatcern glpatcern merged commit cb7ddd5 into master Mar 7, 2024
2 checks passed
@glpatcern glpatcern deleted the fix-writefile-lock branch March 7, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

writefile in cs3 interface does not properly support locking
2 participants
@glpatcern @wkloucek