-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to create webdav references for OCM shares #974
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@@ -1028,6 +1030,12 @@ func (s *svc) handleCS3Ref(ctx context.Context, opaque string) (*provider.Resour | |||
return res.Info, nil | |||
} | |||
|
|||
func (s *svc) handleWebdavRef(ctx context.Context, ri *provider.ResourceInfo) (*provider.ResourceInfo, error) { | |||
// A webdav ref has the following layout: <storage_id>/<opaque_id>@webdav_endpoint | |||
// TODO: Once file transfer functionalities have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to access the remote data by issues a GET/PROPFIND response to obtain the necessary information dynamically.
We can merge this PR and add that later. @ishank011
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I added the TODO there. Once we have that functionality, I'll update this.
@ishank011 we can add |
@labkode Aren't the tags only those specified within square brackets? I'll anyway try and see if this works |
@ishank011 not sure either, test empirically :) |
@ishank011 the creation of the webdav reference has to be optional, for example for Cubbit, they only need to implement the share creation but not propagating it to a storage reference. Can be add a configuration flag that this needs to be explicit? |
No description provided.