Remove Expired Link on Access #959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
reviewed
Jul 10, 2020
PVince81
reviewed
Jul 10, 2020
PVince81
reviewed
Jul 10, 2020
PVince81
reviewed
Jul 10, 2020
changes as per review comments log errors instead of writing to the response abort execution on errors to prevent nil pointer exeptions
labkode
approved these changes
Jul 10, 2020
labkode
requested changes
Jul 10, 2020
|
@PVince81 any update on this? |
|
@labkode setting this one as WIP, as I hacked it around a little bit, and it's lacking some process. We moved it's priority to a future sprint and will retake it soon. |
|
closing in favor of #1361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no background jobs scheduled to wipe out expired resources, for the time being public links are going to be removed on a "on demand" basis, meaning whenever there is an API call that access the list of shares for a given resource, we will check whether the share is expired and delete it if so.
This code will not live in the managers (drivers), since we want the behavior to be consistent across implementations.
Closes owncloud/ocis#372