Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a CS3API compliant data exporter to Mentix #955

Merged
merged 13 commits into from
Jul 9, 2020
Merged

Added a CS3API compliant data exporter to Mentix #955

merged 13 commits into from
Jul 9, 2020

Conversation

Daniel-WWU-IT
Copy link
Contributor

A new HTTP endpoint has been added that exports data in a format compliant to the CS3API ProviderInfo structure.

@labkode
Copy link
Member

labkode commented Jul 8, 2020

@Daniel-WWU-IT some hound linting

@ishank011
Copy link
Contributor

@Daniel-WWU-IT you can just use small-case for the first letter for internal methods. Saves you from adding comments.

@Daniel-WWU-IT
Copy link
Contributor Author

Daniel-WWU-IT commented Jul 8, 2020

@Daniel-WWU-IT you can just use small-case for the first letter for internal methods. Saves you from adding comments.

They aren't internal, otherwise I would have done so. I add comments to types and functions where it makes sense, not just to make the hound happy ;) And these are not the only exported funcs/types that lack comments. If the hound really finds something critical/important, I'll gladly fix that, but some unimportant missing comments...

@ishank011
Copy link
Contributor

Ideally, all the exported methods should have comments, even though they are self-explanatory ;)
Could you point me to those which aren't commented? I might as well fix those.

@Daniel-WWU-IT
Copy link
Contributor Author

Ideally, all the exported methods should have comments, even though they are self-explanatory ;)
Could you point me to those which aren't commented? I might as well fix those.

I think I stumbled upon a few in some other services, not sure if this has changed yet. But I'll go through my code and comment all the obvious ;)

@Daniel-WWU-IT
Copy link
Contributor Author

Comments added... hope I got all places

@ishank011
Copy link
Contributor

Awesome! Thanks!

@labkode labkode merged commit 64d6830 into cs3org:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants