-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a CS3API compliant data exporter to Mentix #955
Conversation
Merge current upstream Reva
Upstream update
Merge upstream repo
Pull upstream
@Daniel-WWU-IT some hound linting |
@Daniel-WWU-IT you can just use small-case for the first letter for internal methods. Saves you from adding comments. |
They aren't internal, otherwise I would have done so. I add comments to types and functions where it makes sense, not just to make the hound happy ;) And these are not the only exported funcs/types that lack comments. If the hound really finds something critical/important, I'll gladly fix that, but some unimportant missing comments... |
Ideally, all the exported methods should have comments, even though they are self-explanatory ;) |
I think I stumbled upon a few in some other services, not sure if this has changed yet. But I'll go through my code and comment all the obvious ;) |
Comments added... hope I got all places |
Awesome! Thanks! |
A new HTTP endpoint has been added that exports data in a format compliant to the CS3API
ProviderInfo
structure.