Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove array from OCS Share update response #919

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Remove array from OCS Share update response #919

merged 1 commit into from
Jul 1, 2020

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Jul 1, 2020

The OCS share response after updating a public share must not contain an
XML "element" tag. To remove it, the fix removes the array around the
response.

The OCS share response after updating a public share must not contain an
XML "element" tag. To remove it, the fix removes the array around the
response.
@PVince81 PVince81 requested a review from refs July 1, 2020 09:37
@PVince81 PVince81 requested a review from labkode as a code owner July 1, 2020 09:37
@PVince81 PVince81 self-assigned this Jul 1, 2020
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 1, 2020

note: I discovered this by comparing the response with the one from OC 10.
then verified using curl that the "element" tag is indeed gone after this fix.

API tests don't work yet as they have other issues, will be enabled later: owncloud/ocis-reva#252 (comment)

@refs refs merged commit 8d8fe39 into cs3org:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants