Allow date-only expiration for public shares #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored to use the common method expirationTimestampFromRequest(). Adjusted parsing code to aligns with the OC 10 API which allows both date and datetime formats to be used.
refs
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored to use the common method expirationTimestampFromRequest().
Adjusted parsing code to aligns with the OC 10 API which allows both
date and datetime formats to be used.
For owncloud/ocis-reva#288
Tested with the matching tagged API test tickets, 4 of them passing now (the other ones blocked by another issue)
@refs @labkode